[RPC] Asynchronous signals. #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobolog
force-pushed
the
async-signals
branch
2 times, most recently
from
9d58f06
to
54ea0c9
Compare
kobolog
force-pushed
the
async-signals
branch
2 times, most recently
from
6c0721f
to
29e7f06
Compare
Boost Signals2 is a good thing, but not really safe in our case due to concurrency issues. This one introduces a new signalling architecture based on asynchronous signal delivery and Cocaine RPC.
Signals don't use queues, but use frozen events. Split these two entities to reduce include burden.
kobolog
force-pushed
the
async-signals
branch
5 times, most recently
from
3356511
to
817e22b
Compare
| typedef typename signal_type::slot_type slot_type; | ||
| result_type | ||
| operator()(const std::shared_ptr<io::basic_slot<Event>>& slot) const { | ||
| auto args = this->args; |
There was a problem hiding this comment.
What if args aren't copyable?
Okay, I see it doesn't make sense to use move-only args.
There was a problem hiding this comment.
Yeah, history won't work in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signals that work.